[6.2] Sema: Fix case where witness thrown error type is a subtype of a type parameter #80965
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
DougGregor
approved these changes
Apr 21, 2025
… parameter In b300068, I changed the `if` condition here to check for the absence of type variables as well as type parameters. This is incorrect; the type variables come up in ValueWitnessRequest, and the type parameters come up in associated type inference. We want the matching to be more lax in the former case. Fixes rdar://149438520.
slavapestov
force-pushed
the
fix-rdar149438520-6.2
branch
from
49901c2 to
dc70a0e
Compare
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.2 cherry-pick of #80963
Description: Allow a non-throwing witness to match a protocol requirement that throws an associated type, because Never is conceptually a subtype of every type, even a type parameter.
Origination: This used to work but was untested. It regressed in Sema: Fix handling of getter typed throws in witness matching #80445.
Tested: New test added.
Radar: rdar://149438520
Reviewed by: @DougGregor